[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] [TCK] nwfilter: Add test cases for ipset



On 04/26/2012 05:13 PM, Eric Blake wrote:
On 04/23/2012 06:20 AM, Stefan Berger wrote:


+  if [ -n "${cmd}" ]; then
+    eval "${cmd}" 2>&1 1>/dev/null
This says output any errors from command to our stdout, and to ignore
normal output of $cmd.  Is that what you meant, or did you want to
ignore both output and errors from $cmd, in which case you should swap
the redirection operators?

The intention was to not get any output from running those test commands. Above unfortunately only solved this for stdout but not for suppressing stderr, so 'ipset: command not found' was still printed. Now I changed this line to

eval "${cmd}" 2>/dev/null 1>/dev/null

and everything is quiet. Not quite sure why the previous notation didn't work... I will post a V2. For this patch to go in I'll also need an ACK for the somewhat longer patch for ipset support:

http://www.redhat.com/archives/libvir-list/2012-April/msg01226.html

   Stefan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]