[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 1/5] Make GVirConfigDomainTimer abstract



On Fri, Apr 13, 2012 at 05:20:14PM +0200, Christophe Fergeau wrote:
> Specialized timer classes will inherit from it
> ---
>  libvirt-gconfig/libvirt-gconfig-domain-timer.c |   22 +---------------------
>  libvirt-gconfig/libvirt-gconfig-domain-timer.h |    4 ----
>  libvirt-gconfig/libvirt-gconfig.sym            |    2 --
>  3 files changed, 1 insertion(+), 27 deletions(-)
> 
> diff --git a/libvirt-gconfig/libvirt-gconfig-domain-timer.c b/libvirt-gconfig/libvirt-gconfig-domain-timer.c
> index 70215ae..67a1812 100644
> --- a/libvirt-gconfig/libvirt-gconfig-domain-timer.c
> +++ b/libvirt-gconfig/libvirt-gconfig-domain-timer.c
> @@ -32,7 +32,7 @@ struct _GVirConfigDomainTimerPrivate
>      gboolean unused;
>  };
>  
> -G_DEFINE_TYPE(GVirConfigDomainTimer, gvir_config_domain_timer, GVIR_CONFIG_TYPE_OBJECT);
> +G_DEFINE_ABSTRACT_TYPE(GVirConfigDomainTimer, gvir_config_domain_timer, GVIR_CONFIG_TYPE_OBJECT);
>  
>  
>  static void gvir_config_domain_timer_class_init(GVirConfigDomainTimerClass *klass)
> @@ -47,23 +47,3 @@ static void gvir_config_domain_timer_init(GVirConfigDomainTimer *timer)
>  
>      timer->priv = GVIR_CONFIG_DOMAIN_TIMER_GET_PRIVATE(timer);
>  }
> -
> -
> -GVirConfigDomainTimer *gvir_config_domain_timer_new(void)
> -{
> -    GVirConfigObject *object;
> -
> -    object = gvir_config_object_new(GVIR_CONFIG_TYPE_DOMAIN_TIMER, "timer", NULL);
> -    return GVIR_CONFIG_DOMAIN_TIMER(object);
> -}
> -
> -
> -GVirConfigDomainTimer *gvir_config_domain_timer_new_from_xml(const gchar *xml,
> -                                                GError **error)
> -{
> -    GVirConfigObject *object;
> -
> -    object = gvir_config_object_new_from_xml(GVIR_CONFIG_TYPE_DOMAIN_TIMER,
> -                                             "timer", NULL, xml, error);
> -    return GVIR_CONFIG_DOMAIN_TIMER(object);
> -}
> diff --git a/libvirt-gconfig/libvirt-gconfig-domain-timer.h b/libvirt-gconfig/libvirt-gconfig-domain-timer.h
> index 11038e2..a7b4332 100644
> --- a/libvirt-gconfig/libvirt-gconfig-domain-timer.h
> +++ b/libvirt-gconfig/libvirt-gconfig-domain-timer.h
> @@ -59,10 +59,6 @@ struct _GVirConfigDomainTimerClass
>  
>  GType gvir_config_domain_timer_get_type(void);
>  
> -GVirConfigDomainTimer *gvir_config_domain_timer_new(void);
> -GVirConfigDomainTimer *gvir_config_domain_timer_new_from_xml(const gchar *xml,
> -                                                      GError **error);
> -
>  G_END_DECLS
>  
>  #endif /* __LIBVIRT_GCONFIG_DOMAIN_TIMER_H__ */
> diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym
> index 2378a3c..77d0a45 100644
> --- a/libvirt-gconfig/libvirt-gconfig.sym
> +++ b/libvirt-gconfig/libvirt-gconfig.sym
> @@ -227,8 +227,6 @@ LIBVIRT_GCONFIG_0.0.7 {
>  	gvir_config_domain_sound_set_model;
>  
>  	gvir_config_domain_timer_get_type;
> -	gvir_config_domain_timer_new;
> -	gvir_config_domain_timer_new_from_xml;
>  
>  	gvir_config_domain_video_get_type;
>  	gvir_config_domain_video_model_get_type;

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]