[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] More coverity findings addressed



More bug extermination in the category of:

Error: CHECKED_RETURN:

/libvirt/src/conf/network_conf.c:595:
check_return: Calling function "virAsprintf" without checking return value (as is done elsewhere 515 out of 543 times).

/libvirt/src/qemu/qemu_process.c:2780:
unchecked_value: No check of the return value of "virAsprintf(&msg, "was paused (%s)", virDomainPausedReasonTypeToString(reason))".

/libvirt/tests/commandtest.c:809:
check_return: Calling function "setsid" without checking return value (as is done elsewhere 4 out of 5 times).

/libvirt/tests/commandtest.c:830:
unchecked_value: No check of the return value of "virTestGetDebug()".

/libvirt/tests/commandtest.c:831:
check_return: Calling function "virTestGetVerbose" without checking return value (as is done elsewhere 41 out of 42 times).

/libvirt/tests/commandtest.c:833:
check_return: Calling function "virInitialize" without checking return value (as is done elsewhere 18 out of 21 times).


One note about the error in commandtest line 809: setsid() seems to fail when running the test -- could be removed ?

---
 src/conf/network_conf.c |    7 ++-----
 src/qemu/qemu_process.c |    4 ++--
 tests/commandtest.c     |    9 +++++----
 3 files changed, 9 insertions(+), 11 deletions(-)

Index: libvirt-acl/src/conf/network_conf.c
===================================================================
--- libvirt-acl.orig/src/conf/network_conf.c
+++ libvirt-acl/src/conf/network_conf.c
@@ -590,12 +590,9 @@ virNetworkDNSSrvDefParseXML(virNetworkDN
     }

     if (strlen(service) > DNS_RECORD_LENGTH_SRV) {
-        char *name = NULL;
-
- virAsprintf(&name, _("Service name is too long, limit is %d bytes"), DNS_RECORD_LENGTH_SRV);
         virNetworkReportError(VIR_ERR_XML_DETAIL,
-                              "%s", name);
-        VIR_FREE(name);
+ _("Service name is too long, limit is %d bytes"),
+                              DNS_RECORD_LENGTH_SRV);
         goto error;
     }

Index: libvirt-acl/src/qemu/qemu_process.c
===================================================================
--- libvirt-acl.orig/src/qemu/qemu_process.c
+++ libvirt-acl/src/qemu/qemu_process.c
@@ -2777,8 +2777,8 @@ qemuProcessUpdateState(struct qemud_driv
         } else {
             newState = VIR_DOMAIN_PAUSED;
             newReason = reason;
-            virAsprintf(&msg, "was paused (%s)",
-                        virDomainPausedReasonTypeToString(reason));
+            ignore_value(virAsprintf(&msg, "was paused (%s)",
+ virDomainPausedReasonTypeToString(reason)));
         }
     } else if (state == VIR_DOMAIN_SHUTOFF && running) {
         newState = VIR_DOMAIN_RUNNING;
Index: libvirt-acl/tests/commandtest.c
===================================================================
--- libvirt-acl.orig/tests/commandtest.c
+++ libvirt-acl/tests/commandtest.c
@@ -806,7 +806,7 @@ mymain(void)
         return EXIT_FAILURE;

     setpgid(0, 0);
-    setsid();
+    ignore_value(setsid());

     /* Our test expects particular fd values; to get that, we must not
      * leak fds that we inherited from a lazy parent.  At the same
@@ -827,10 +827,11 @@ mymain(void)

     /* Prime the debug/verbose settings from the env vars,
      * since we're about to reset 'environ' */
-    virTestGetDebug();
-    virTestGetVerbose();
+    ignore_value(virTestGetDebug());
+    ignore_value(virTestGetVerbose());

-    virInitialize();
+    if (virInitialize() < 0)
+        return EXIT_FAILURE;

     /* Phase two of killing interfering fds; see above.  */
     fd = 3;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]