[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Yet more coverity fixes



On 04/30/2012 12:55 PM, Daniel P. Berrange wrote:
On Mon, Apr 30, 2012 at 12:42:37PM -0400, Stefan Berger wrote:

  >  /libvirt/daemon/libvirtd.c:168:
  >  leaked_handle: Handle variable "stdinfd" going out of scope leaks the handle.

This is refering to the 3rd line here:

             switch (nextpid) {
             case 0: /* grandchild */
                 return statuspipe[1];

Neither the original 'cleanup:' label, nor any of the 3 you added
will ever execute in the codepath that coverity is complaining
about.
Hm, dropping the libvirtd.c changes...

   Stefan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]