[libvirt] [PATCH] Ensure libvirt_lxc process loads the live XML config

Eric Blake eblake at redhat.com
Mon Apr 30 17:58:50 UTC 2012


On 04/30/2012 08:52 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> Currently the libvirt_lxc process uses VIR_DOMAIN_XML_INACTIVE
> when loading the XML for the container. This means it looses

s/looses/loses/

> any dynamic data such as the, just allocated, SELinux label.
> 
> Further there is an inconsistency in the libvirt LXC driver
> whereby it saves the live config XML and then later overwrites
> the file with the live status XML instead. Add a comment about
> this for future reference.
> 
> * src/lxc/lxc_controller.c: Remove VIR_DOMAIN_XML_INACTIVE
>   when loading XML
> * src/lxc/lxc_driver.c: Add comment about inconsistent
>   config file formats
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/lxc/lxc_controller.c |    2 +-
>  src/lxc/lxc_driver.c     |   14 ++++++--------
>  2 files changed, 7 insertions(+), 9 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120430/c59bdf27/attachment-0001.sig>


More information about the libvir-list mailing list