[libvirt] [PATCH libvirt-glib] Don't hold events lock when dispatching free callbacks

Christophe Fergeau cfergeau at redhat.com
Mon Aug 27 15:19:53 UTC 2012


On Mon, Aug 20, 2012 at 04:14:52PM +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> The _event_timeout_remove and _event_handle_remove methods
> were holding onto the global lock when invoking the free
> callback. This is a violation of the libvirt events API
> contract which requires free callbacks to be invoked in
> a re-entrant safe context.

Is it a possible fix for the infamous boxes issue where it sometimes stop
getting events from libvirt? Regardless of that, nice catch!

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120827/6cd937f3/attachment-0001.sig>


More information about the libvir-list mailing list