[libvirt] [PATCH] Syntax error in src/qemu/qemu_hotplug.c

Ryan Bourgeois bluedragonx at gmail.com
Wed Aug 1 14:02:09 UTC 2012


Hah, thanks. I guess my timing was just right to hit the wrong commit when
I pulled it down.

-Ryan

On Wed, Aug 1, 2012 at 2:35 AM, Peter Krempa <pkrempa at redhat.com> wrote:

> On 07/31/12 17:20, Ryan Bourgeois wrote:
>
>> Fixed use of colon as statement terminator.
>>
>> This is against the latest git master. My email client chomps
>> whitespace so I've attached the patch.
>>
>> Ryan Bourgeois
>>
>>
> Thanks for sending the patch! Unfortunately it's no longer relevant as
> it's already fixed by commit:
>
> commit 2beed2daaf6539a13e915073343a82**384e3a135d
> Author: Marc-André Lureau <marcandre.lureau at gmail.com>
> Date:   Tue Jul 31 19:51:41 2012 +0200
>
>     qemu: syntax fix
>
>     Pushed without ack, under the trivial rule.
>
> diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
> index ceffe22..f5f96ed 100644
> --- a/src/qemu/qemu_hotplug.c
> +++ b/src/qemu/qemu_hotplug.c
> @@ -1170,7 +1170,7 @@ int qemuDomainAttachHostDevice(**struct
> qemud_driver *driver,
>
>          if (usbDeviceListAdd(list, usb) < 0) {
>              usbFreeDevice(usb);
> -            usb = NULL:
> +            usb = NULL;
>              goto cleanup;
>          }
>
> For the whitespace damaging issue I recommend using git send-email that
> works just fine.
>
> Peter
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120801/d6ef84b5/attachment-0001.htm>


More information about the libvir-list mailing list