[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v10 9/9] parallels: implement VM creation



On 07/31/2012 09:34 PM, Daniel Veillard wrote:
> On Tue, Jul 31, 2012 at 10:56:13PM +0400, Dmitry Guryanov wrote:
>> To create a new VM in Parallels Clud Server we should issue
>> "prlctl create" command, and give path to the directory,
>> where VM should be created. VM's storage will be in that
>> directory later. So in this first version find out location
>> of first VM's hard disk and create VM there.
>>

>   as well as this one led to 'make syntax-check errors', I squashed in
>   the following which looks a safe way to try to provide informations,
> 
> Daniel
> 
> diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
> index e1bc83e..b57ac96 100644
> --- a/src/parallels/parallels_driver.c
> +++ b/src/parallels/parallels_driver.c
> @@ -1568,7 +1568,8 @@ parallelsCreateVm(virConnectPtr conn, virDomainDefPtr def)
>           * let's report error if no disk until better solution
>           * will be found */
>          virReportError(VIR_ERR_INVALID_ARG,
> -                       _("Can't create VM without hard disks"));
> +                       _("Can't create VM '%s' without hard disks"),
> +                       (def->name ? def->name : "no name"));

This doesn't translate well.  Perhaps

s/"no name"/_("(unnamed)")/

would be better.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]