[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] ESX: Add "Byte" datatype



2012/8/1 Ata E Husain Bohra <ata husain hotmail com>:
> Append "Byte" to set of predefined object data types.
>
> Signed-off-by: Ata E Husain Bohra <ata husain hotmail com>
> ---
>  src/esx/esx_vi_generator.py |    1 +
>  src/esx/esx_vi_types.c      |   57 +++++++++++++++++++++++++++++++++++++++++++
>  src/esx/esx_vi_types.h      |   28 +++++++++++++++++++++
>  3 files changed, 86 insertions(+)

> +/* esxVI_Byte_Serialize */
> +ESX_VI__TEMPLATE__SERIALIZE(Byte,
> +{
> +    virBufferAsprintf(output, "%c", (int8_t)item->value);
> +})

Why did you used %c here, this will print an ASCII character instead
of a number. %d should be used here.

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]