[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/13] Turn virDomainObjPtr into a virObjectPtr



On Thu, Aug 02, 2012 at 11:13:20AM +0100, Daniel P. Berrange wrote:
> On Wed, Aug 01, 2012 at 04:39:24PM +0800, Hu Tao wrote:
> > >  void
> > >  virBlkioDeviceWeightArrayClear(virBlkioDeviceWeightPtr deviceWeights,
> > >                                 int ndevices)
> > > @@ -723,7 +738,7 @@ virDomainObjListDataFree(void *payload, const void *name ATTRIBUTE_UNUSED)
> > >  {
> > >      virDomainObjPtr obj = payload;
> > >      virDomainObjLock(obj);
> > > -    if (virDomainObjUnref(obj) > 0)
> > > +    if (!virObjectUnref(obj))
> > >          virDomainObjUnlock(obj);
> > >  }
> > 
> > I suppose you mean
> > 
> >        if (virObjectUnref(obj))
> > 
> > here.

Oh, yes I do.

> > But, I can't see any reason to lock then unref then unlock, just unref
> > is enough.
> 
> I didn't want to change multiple things at the same time. Simplification
> of locking in various places can follow later.
> 

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]