[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix typo in qemuDomainModifyDeviceFlags



On 02.08.2012 16:42, Peter Krempa wrote:
> On 08/02/12 16:30, Michal Privoznik wrote:
>> One of our latest commits fbe87126 introduced this nasty typo:
>> func(vmdef, ...); where func() dereference vmdef->ncontrollers,
>> and vmdef was initialized to NULL. This leaves us with unconditional
>> immediate segfault. It should be vm->def instead.
>> ---
>>
>> Despite this could qualify to be pushed under trivial rule, I'd feel more
>> comfortable with an ACK.
>>
>>   src/qemu/qemu_driver.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
> 
> Gah, mea culpa. ACK.
> 
> Peter

Thanks, pushed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]