[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for S3/S4 state configuration



On 08/02/2012 06:05 AM, Martin Kletzander wrote:
> This patch adds support for running qemu guests with the required
> parameters to forcefully enable or disable BIOS advertising of S3 and
> S4 states.  The support for this is added to capabilities and there is
> also a qemu command parameter parsing implemented.
> ---
>  src/qemu/qemu_capabilities.c |    7 +++
>  src/qemu/qemu_capabilities.h |    2 +
>  src/qemu/qemu_command.c      |  103 ++++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_driver.c       |   17 +++++++
>  4 files changed, 129 insertions(+), 0 deletions(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 85c49a2..b4a662f 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -169,6 +169,8 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST,
>                "virtio-s390",
>                "balloon-event",
> 
> +              "disable-s3", /* 100 */
> +              "disable-s4",

Do we need two capability bits here, or are we guaranteed that both
command line options are always present or absent together and one bit
sufficient?  If we use just one bit, maybe naming it 'disable-pm' would
be reasonable.  Then again, the qemu folks might say that it really
should be two independent bits, such as if it is easier to backport just
one of the two controls to an older qemu.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]