[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/3] Add per-guest S3/S4 state configuration



On 08/03/2012 09:46 AM, Paolo Bonzini wrote:
> Il 03/08/2012 07:16, Doug Goldstein ha scritto:
>>>> You are proposing /domain/pm; but we also have /domain/os/bios, would
>>>> this be better as a subelement /domain/os/bios/pm, since it is related
>>>> to bios options?
>> I would say that /domain/os/bios/pm isn't the correct place because
>> /domain/os relates only to OS booting while Power Management is
>> outside of the scope of booting. In fact /domain/os/bios simply
>> controls whether the BIOS output will be over VGA or over serial.
>> Features specific to the system are typically kept as top level items,
>> which matches /domain/pm. I would however say that using the terms
>> ACPI, s3 and s4 isn't good design for the XML. You can leave that to
>> documentation but /domain/pm/suspend-to-mem and
>> /domain/pm/suspend-to-disk are better so that the same XML structure
>> can be used for PPC. They have concepts similar to s3 and s4 (I only
>> briefly Googled this) but they're named completely differently. The
>> only under place I could see this would be /domain/features/acpi. If
>> its there then s3 and s4 potentially make sense, but then we're left
>> without a place for PPC to tie in.
> 
> I would put it under /domain/features/pm.
> 
> Paolo
> 

In v1 I had this in /domain/features, but due to the way the features
are parsed (they are just flags) I couldn't make it tristate as danpb
suggested (and he was right), so I had to choose a different place, but
otherwise it would fit there logically, yes.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]