[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [glib PATCH V1] Add bindings for virDomainSnapshotCreateFlags



ACK

On Fri, Aug 03, 2012 at 01:05:19PM +0200, Jovanka Gulicoska wrote:
> ---
>  libvirt-gobject/libvirt-gobject-domain.c |  2 +-
>  libvirt-gobject/libvirt-gobject-domain.h | 25 +++++++++++++++++++++++++
>  libvirt-gobject/libvirt-gobject.sym      |  1 +
>  3 files changed, 27 insertions(+), 1 deletion(-)
> 
> diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c
> index 31aa61a..8820a54 100644
> --- a/libvirt-gobject/libvirt-gobject-domain.c
> +++ b/libvirt-gobject/libvirt-gobject-domain.c
> @@ -1278,7 +1278,7 @@ GList *gvir_domain_get_devices(GVirDomain *domain,
>   * gvir_domain_create_snapshot:
>   * @dom: the domain
>   * @custom_conf: (allow-none): configuration of snapshot or NULL
> - * @flags: the flags
> + * @flags: bitwise-OR of #GVirDomainSnapshotCreateFlags
>   * @err: (allow-none):Place-holder for error or NULL
>   *
>   * Returns: (transfer full): snapshot of domain. The returned object should be
> diff --git a/libvirt-gobject/libvirt-gobject-domain.h b/libvirt-gobject/libvirt-gobject-domain.h
> index d10fa8d..f3a36fc 100644
> --- a/libvirt-gobject/libvirt-gobject-domain.h
> +++ b/libvirt-gobject/libvirt-gobject-domain.h
> @@ -130,6 +130,31 @@ typedef enum {
>      GVIR_DOMAIN_SHUTDOWN_GUEST_AGENT    = VIR_DOMAIN_SHUTDOWN_GUEST_AGENT,
>  } GVirDomainShutdownFlags;
>  
> +/**
> + * GVirDomainSnapshotCreateFlags:
> + * @GVIR_DOMAIN_SNAPSHOT_NONE: No flags
> + * @GVIR_DOMAIN_SNAPSHOT_REDEFINE: Restore or alter metadata
> + * @GVIR_DOMAIN_SNAPSHOT_CURRENT: With redefine, make snapshot current
> + * @GVIR_DOMAIN_SNAPSHOT_NO_METADATA: Make snapshot without remembering it
> + * @GVIR_DOMAIN_SNAPSHOT_HALT: Stop running guest after snapshot
> + * @GVIR_DOMAIN_SNAPSHOT_DISK_ONLY: Disk snapshot, not system checkpoint
> + * @GVIR_DOMAIN_SNAPSHOT_REUSE_EXT: Reuse any existing external files
> + * @GVIR_DOMAIN_SNAPSHOT_QUIESCE: Use guest agent to quiesce all mounter
> + *                                file systems within the domain
> + * @GVIR_DOMAIN_SNAPSHOT_ATOMIC: Atomically avoid partial changes
> + */
> +typedef enum {
> +    GVIR_DOMAIN_SNAPSHOT_NONE         = 0,
> +    GVIR_DOMAIN_SNAPSHOT_REDEFINE     = VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE,
> +    GVIR_DOMAIN_SNAPSHOT_CURRENT      = VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT,
> +    GVIR_DOMAIN_SNAPSHOT_NO_METADATA  = VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA,
> +    GVIR_DOMAIN_SNAPSHOT_HALT         = VIR_DOMAIN_SNAPSHOT_CREATE_HALT,
> +    GVIR_DOMAIN_SNAPSHOT_DISK_ONLY    = VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY,
> +    GVIR_DOMAIN_SNAPSHOT_REUSE_EXT    = VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT,
> +    GVIR_DOMAIN_SNAPSHOT_QUIESCE      = VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE,
> +    GVIR_DOMAIN_SNAPSHOT_ATOMIC       = VIR_DOMAIN_SNAPSHOT_CREATE_ATOMIC,
> +} GVirDomainSnapshotCreateFlags;
> +
>  typedef struct _GVirDomainInfo GVirDomainInfo;
>  struct _GVirDomainInfo
>  {
> diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym
> index 5d15e7a..4e2ef95 100644
> --- a/libvirt-gobject/libvirt-gobject.sym
> +++ b/libvirt-gobject/libvirt-gobject.sym
> @@ -182,6 +182,7 @@ LIBVIRT_GOBJECT_0.0.9 {
>  LIBVIRT_GOBJECT_0.1.1 {
>    global:
>  	gvir_domain_shutdown_flags_get_type;
> +	gvir_domain_snapshot_create_flags_get_type;
>  	gvir_domain_xml_flags_get_type;
>  
>  	gvir_domain_create_snapshot;
> -- 
> 1.7.11.2
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: pgpjUXHxcwPpw.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]