[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v10 9/9] parallels: implement VM creation



On 08/03/2012 04:52 AM, Alex Jia wrote:
> On 08/01/2012 10:51 PM, Eric Blake wrote:
>> On 07/31/2012 09:34 PM, Daniel Veillard wrote:
>>> On Tue, Jul 31, 2012 at 10:56:13PM +0400, Dmitry Guryanov wrote:
>>>> To create a new VM in Parallels Clud Server we should issue
> 
> s/Clud/Cloud/ ?

Yeah, but the commit message is already in place now.  Oh well.


>>>           virReportError(VIR_ERR_INVALID_ARG,
>>> -                       _("Can't create VM without hard disks"));
>>> +                       _("Can't create VM '%s' without hard disks"),
>>> +                       (def->name ? def->name : "no name"));
>> This doesn't translate well.  Perhaps
>>
>> s/"no name"/_("(unnamed)")/
>>
>> would be better.

I'm pushing this under the trivial rule:

From d55b72324d925c644920c91fd57c178dcd4ce8ce Mon Sep 17 00:00:00 2001
From: Eric Blake <eblake redhat com>
Date: Fri, 3 Aug 2012 10:22:08 -0600
Subject: [PATCH] parallels: translate error message

Without this patch, the English phrase 'no name' would appear
literally within the remaining translated message.

* src/parallels/parallels_driver.c (parallelsCreateVm)
(parallelsDomainDefineXML): Tweak error message.
---
 src/parallels/parallels_driver.c |  4 ++--
 src/rpc/virnetserver.c           | 18 ++----------------
 2 files changed, 4 insertions(+), 18 deletions(-)

diff --git a/src/parallels/parallels_driver.c
b/src/parallels/parallels_driver.c
index b57ac96..c26ea25 100644
--- a/src/parallels/parallels_driver.c
+++ b/src/parallels/parallels_driver.c
@@ -1569,7 +1569,7 @@ parallelsCreateVm(virConnectPtr conn,
virDomainDefPtr def)
          * will be found */
         virReportError(VIR_ERR_INVALID_ARG,
                        _("Can't create VM '%s' without hard disks"),
-                       (def->name ? def->name : "no name"));
+                       def->name ? def->name : _("(unnamed)"));
         return -1;
     }

@@ -1659,7 +1659,7 @@ parallelsDomainDefineXML(virConnectPtr conn, const
char *xml)
         if (!dom) {
             virReportError(VIR_ERR_INTERNAL_ERROR,
                            _("Domain for '%s' is not defined after
creation"),
-                           (def->name ? def->name : "no name"));
+                           def->name ? def->name : _("(unnamed)"));
             goto cleanup;
         }
     }
-- 
1.7.11.2

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]