[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Migrate at unlimited speed by default



On 08/03/2012 01:12 PM, Jiri Denemark wrote:
> On Fri, Aug 03, 2012 at 13:06:27 -0600, Eric Blake wrote:
>> On 08/03/2012 12:16 PM, Jiri Denemark wrote:
>>> Previously, qemu did not respond to monitor commands during migration if
>>> the limit was too high. This prevented us from raising the limit
>>> earlier. The qemu issue seems to be fixed (according to my testing) and
>>> we may remove the 32Mb/s limit.
>>> ---
>>>  src/qemu/qemu_domain.c    | 2 +-
>>>  src/qemu/qemu_domain.h    | 5 ++---
>>>  src/qemu/qemu_migration.c | 4 ++--
>>>  3 files changed, 5 insertions(+), 6 deletions(-)
>>
>> How does this differ from commit 9f71368?  That is, aren't we already
>> supporting unlimited speed since your patch in March?
> 
> That commit enabled unlimited speed only when migrating to a file. This patch
> removes the limit even for over-the-net migrations.

Do we need a capability bit, such as a minimum version of qemu at which
this works, so that we don't run into problems with older qemu where
unlimited still starves the monitor?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]