[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] remote: Clean up coding style and refactor remote connection opening



On 08/03/2012 08:03 AM, Peter Krempa wrote:
> Remove spaces before fucntion calls and some other coding nits in some

s/fucntion/function/

> parts of the remote driver and refactor getting of URI argument
> components into variables used by libvirt later on.
> ---
>  src/remote/remote_driver.c |  292 +++++++++++++++++++++-----------------------
>  1 files changed, 142 insertions(+), 150 deletions(-)

ACK; reasonable cleanups before the meat of the series.

> +        goto no_memory;
> +
> +    if ((conn->uri && conn->uri->user) &&

The () around the first && is redundant, but doesn't hurt.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]