[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: Remove console stream callback only when freeing console helper



On 08/03/12 18:40, Eric Blake wrote:
On 08/03/2012 03:27 AM, Peter Krempa wrote:
Commit ba226d334acbc49f6751b430e0c4e00f69eef6bf tried to fix crash of
the daemon when a domain with a open console was destroyed. The fix was

s/a open/an open/

wrong as it tried to remove the callback also when the stream was
aborted, where at that point the fd stream driver was already freed and
removed.

This patch clears the callbacks with a helper right before the hash is
freed, so that it doesn't interfere with other codepaths where the
stream object is freed.
---
  src/conf/virconsole.c |   16 +++++++++++++---
  1 files changed, 13 insertions(+), 3 deletions(-)

ACK.


Pushed. Thanks!

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]