[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/9] util: add openvswitch case to virNetDevVPortProfileEqual



On Sun, Aug 5, 2012 at 12:16 AM, Laine Stump <laine laine org> wrote:
> This function was overlooked when openvswitch support was
> added. Fortunately it's only use for update-device, which is
> relatively new and seldom-used.
> ---
>  src/util/virnetdevvportprofile.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/util/virnetdevvportprofile.c b/src/util/virnetdevvportprofile.c
> index 506240b..ac5aa24 100644
> --- a/src/util/virnetdevvportprofile.c
> +++ b/src/util/virnetdevvportprofile.c
> @@ -107,6 +107,12 @@ virNetDevVPortProfileEqual(virNetDevVPortProfilePtr a, virNetDevVPortProfilePtr
>              return false;
>          break;
>
> +    case VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH:
> +        if (STRNEQ(a->profileID, b->profileID) ||
> +            memcmp(a->interfaceID, b->interfaceID, VIR_UUID_BUFLEN) != 0)
> +            return false;
> +        break;
> +
>      default:
>          break;
>      }
> --
> 1.7.11.2
>
> --

If I understand your commit message correctly, it appears this was
omitted in a previous patchset and needed to be part of the
switch/case. The change looks good so ACK.

-- 
Doug Goldstein


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]