[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 02/10] Convert public datatypes to inherit from virObject



On 08/06/2012 10:29 AM, Eric Blake wrote:
> On 08/06/2012 10:28 AM, Eric Blake wrote:
>> On 08/06/2012 05:52 AM, Daniel P. Berrange wrote:
>>> From: "Daniel P. Berrange" <berrange redhat com>
>>>
>>> This converts the following public API datatypes to use the
>>> virObject infrastructure:
>>
> 
>>
>> ACK with the doc fix.
> 
> I spoke too soon, 'make check' fails:
> 
>   GEN    check-symfile
> Expected symbol virConnectClass is not in ELF library
> Expected symbol virDomainClass is not in ELF library
> Expected symbol virDomainSnapshotClass is not in ELF library
> Expected symbol virInterfaceClass is not in ELF library
> Expected symbol virNetworkClass is not in ELF library
> Expected symbol virNodeDeviceClass is not in ELF library
> Expected symbol virNWFilterClass is not in ELF library
> Expected symbol virSecretClass is not in ELF library
> Expected symbol virStoragePoolClass is not in ELF library
> Expected symbol virStorageVolClass is not in ELF library
> Expected symbol virStreamClass is not in ELF library
> make[3]: *** [check-symfile] Error 1

Squash this in to fix the problem.

diff --git i/src/check-symfile.pl w/src/check-symfile.pl
index 73cdfcd..ab187ee 100755
--- i/src/check-symfile.pl
+++ w/src/check-symfile.pl
@@ -34,7 +34,7 @@ foreach my $elflib (@elflibs) {
     open NM, "-|", "nm", $elflib or die "cannot run 'nm $elflib': $!";

     while (<NM>) {
-        next unless /^\S+\s(?:T|D)\s(\S+)\s*$/;
+        next unless /^\S+\s(?:[TDB])\s(\S+)\s*$/;

         $gotsyms{$1} = 1;
     }

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]