[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Don't check the 'connect' command in virsh-all test

On 08/07/2012 05:03 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> The 'virsh-all' test case will invoke each virsh command with
> no args. With the 'connect' command this causes virsh to try
> to connect to the default URI, which in turn tries to spawn
> libvirtd. This is not something we want todo in the test suite,
> so skip the 'connect' command.
> ---
>  tests/virsh-all |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK.  I've mentioned the issue before, and even wondered whether it
would make sense to alter the semantics of the 'connect' command with no
arguments to instead reconnect to the current URI instead of
reconnecting to the default URI, but never got around to polishing a
patch into something I like.  So this is a decent compromise of just
avoiding the problem altogether.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]