[libvirt] [PATCH 1/5] remote: Clean up coding style and refactor remote connection opening

Peter Krempa pkrempa at redhat.com
Thu Aug 9 09:42:45 UTC 2012


On 08/03/12 22:24, Eric Blake wrote:
> On 08/03/2012 08:03 AM, Peter Krempa wrote:
>> Remove spaces before fucntion calls and some other coding nits in some
>
> s/fucntion/function/
>
>> parts of the remote driver and refactor getting of URI argument
>> components into variables used by libvirt later on.
>> ---
>>   src/remote/remote_driver.c |  292 +++++++++++++++++++++-----------------------
>>   1 files changed, 142 insertions(+), 150 deletions(-)
>
> ACK; reasonable cleanups before the meat of the series.
>
>> +        goto no_memory;
>> +
>> +    if ((conn->uri && conn->uri->user) &&
>
> The () around the first && is redundant, but doesn't hurt.
>

I fixed the nits and pushed. I'll post a rebased and version of this set 
to get virObject support also into this connection driver.

Thanks for the review.

Peter




More information about the libvir-list mailing list