[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Fix dynamic deep copy



2012/8/6 Michal Privoznik <mprivozn redhat com>:
> On 05.08.2012 10:38, Matthias Bolte wrote:
>> The static deep copy allocates storage for the copy. The dynamic
>> version injected the dynamic dispatch after the allocation. This
>> triggered the invalid argument check in the dynamically dispatched
>> deep copy call. The deep copy function expects its dest parameter
>> to be a pointer to a NULL-pointer. This expectation wasn't met due
>> to the dispatching deep copy doing the allocation before the call.
>>
>> Fix this by dynamically dispatching to the correct type before the
>> allocation.
>> ---
>>  src/esx/esx_vi_types.c |   35 ++++++++++++++++++++++++++++++-----
>>  1 files changed, 30 insertions(+), 5 deletions(-)
>>
>
> ACK

Thanks, pushed.

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]