[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/8] Fix error reporting in virSecuritySELinuxGenNewContext



On 08/10/2012 07:47 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The virSecuritySELinuxGenNewContext method was not reporting any
> errors, leaving it upto the caller to report a generic error.

s/upto/up to/

> In addition it could potentially trigger a strdup(NULL) in an
> OOM scenario. Move all error porting into the

s/porting/reporting/

> virSecuritySELinuxGenNewContext method where accurate info
> can be provided
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/security/security_selinux.c | 67 +++++++++++++++++++++++------------------
>  1 file changed, 37 insertions(+), 30 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]