[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] conf: add <vlan> element to network and domain interface elements



On Mon, Aug 13, 2012 at 12:54:14AM -0400, Laine Stump wrote:
> The following config elements now support multiple <vlan> subelements:
> 
> within a domain: <interface>, and the <actual> subelement of <interface>
> within a network: the toplevel, as well as any <portgroup>
> 
> If multiple vlan elements are given, it is assumed that vlan trunking
> is being requested. If trunking is required with only a single tag,
> the attribute "trunk='yes'" should be added.

I'm not sure I like the fact that there was 2 different configs
which can both enable vlan trunking. I can understand why you
don't want to repeat 'trunk=yes' on all <vlan> elements, but
I feel that if trunking is enabled, there should be something
visible in the XML to that effect.

Also I'm concerned about what we do if we need to maintain
further attributes related to vlans in the future.

I think it'd be more future proof to use

  <vlan trunk='yes|no'>
    <tag id='42'/>
    ...more <tag>...
  </vlan>

even if it is slightly more verbose in the single tag case.

> 
> Some examples:
> 
>   <interface type='hostdev'/>
>     <vlan tag='42'/>
>     <mac address='52:54:00:12:34:56'/>
>     ...
>   </interface>
> 
>   <network>
>     <name>vlan-net</name>
>     <vlan tag='30' trunk='yes'/>
>     <virtualport type='openvswitch'/>
>   </network>
> 
>   <interface type='network'/>
>     <source network='vlan-net'/>
>     ...
>   </interface>
> 
>   <network>
>     <name>trunk-vlan</name>
>     <vlan tag='42'/>
>     <vlan tag='43'/>
>     ...
>   </network>
> 
>   <network>
>     <name>multi</name>
>     ...
>     <portgroup name='production'/>
>       <vlan tag='42'/>
>     </portgroup>
>     <portgroup name='test'/>
>       <vlan tag='666'/>
>     </portgroup>
>   </network>
> 
>   <interface type='network'/>
>     <source network='multi' portgroup='test'/>
>     ...
>   </interface>

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]