[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] distcheck issues on maint and master



On 08/13/2012 07:56 AM, Cole Robinson wrote:

> I tried to reproduce on master, but it has its own set of issues:
> 
> IOError: [Errno 13] Permission denied: '../../src/hyperv/hyperv_wmi.generated.h'
>     types_typedef = open_and_print(os.path.join(output_dirname,
> "esx_vi_types.generated.typedef"))
>   File "../../src/esx/esx_vi_generator.py", line 1492, in open_and_print
>     return open(filename, "wb")
> IOError: [Errno 13] Permission denied:

Sounds like we have a case of a file that gets included in the tarballs,
but where the makefile rules think it is out of date and tries to
regenerate it.  Either it should always be generated (and not part of
the tarball), or we need to audit the dependencies to make sure that it
does not need rebuilding when used from a pristine tarball.  I'll try to
take a look into this one later this week (my past experience with dist
bugs like this is that they take a good chunk of dedicated time on my
part to get to a real root cause).

> 
> $ git revert 1bfb47dfe61c3cf9a716db072cbe22f26e980081
> [master f5a9a90] Revert "Make ESX & Hyper-V code generator safe with parallel
> builds"

So that means that our conversion to using a stamp file is the real
culprit.  It may be as simple as just making sure the stamp file is also
part of the tarball.

> 
> Then I get:
> 
>   GEN      check-symfile
> Can't open perl script "../../src/check-symfile.pl": No such file or directory
> make[4]: *** [check-symfile] Error 2
> 
> Which I fixed with:
> 
> $ git diff
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 5ae84b1..a5223f2 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -331,7 +331,7 @@ else !WITH_REMOTE
>  # re-generated when configured --without-remote.
>  check-protocol:
>  endif
> -EXTRA_DIST += $(PROTOCOL_STRUCTS)
> +EXTRA_DIST += $(PROTOCOL_STRUCTS) check-symfile.pl

Yes, this is correct.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]