[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4] json: fix interface locale dependency



On 08/13/2012 10:02 AM, Martin Kletzander wrote:
> libvirt creates invalid commands if wrong locale is selected. For
> example with locale that uses comma as a decimal point, JSON commands
> created with decimal numbers are invalid because comma separates the
> entries in JSON. Fortunately even when decimal point is affected,
> thousands grouping is not, because for grouping to be enabled with
> *printf, there has to be an apostrophe flag specified (and supported).
> 
> This patch adds specific internal function for converting doubles to
> strings with C locale.
> --
> v4:
>  - changed according to Eric's suggestions
> ---
>  bootstrap.conf           |    1 +
>  configure.ac             |    4 +-
>  src/libvirt_private.syms |    1 +
>  src/util/json.c          |    2 +-
>  src/util/util.c          |   63 ++++++++++++++++++++++++++++++++++++++++++++++
>  src/util/util.h          |    3 ++
>  6 files changed, 71 insertions(+), 3 deletions(-)

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]