[libvirt] [PATCHv2 3/5] conf: output forward device connections count in network XML

Laine Stump laine at laine.org
Tue Aug 14 07:10:19 UTC 2012


It may be useful for management applications to know which physical
network devices are in use by guests. This information is already
available in the network objects, but wasn't output in the XML. This
patch outputs it whan the INACTIVE flag isn't set (and if it's non-0).
---
 src/conf/network_conf.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 905c644..ca5b759 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -1495,8 +1495,14 @@ char *virNetworkDefFormat(const virNetworkDefPtr def, unsigned int flags)
         if (def->nForwardIfs &&
             (!def->nForwardPfs || !(flags & VIR_NETWORK_XML_INACTIVE))) {
             for (ii = 0; ii < def->nForwardIfs; ii++) {
-                virBufferEscapeString(&buf, "    <interface dev='%s'/>\n",
+                virBufferEscapeString(&buf, "    <interface dev='%s'",
                                       def->forwardIfs[ii].dev);
+                if (!(flags & VIR_NETWORK_XML_INACTIVE) &&
+                    (def->forwardIfs[ii].connections > 0)) {
+                    virBufferAsprintf(&buf, " connections='%d'",
+                                      def->forwardIfs[ii].connections);
+                }
+                virBufferAddLit(&buf, "/>\n");
             }
         }
         if (def->nForwardPfs || def->nForwardIfs)
-- 
1.7.11.2




More information about the libvir-list mailing list