[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v10 6/7] block: Enable qemu_open/close to work with fd sets





On 08/14/2012 08:07 AM, Kevin Wolf wrote:
Am 13.08.2012 16:08, schrieb Corey Bryant:
When qemu_open is passed a filename of the "/dev/fdset/nnn"
format (where nnn is the fdset ID), an fd with matching access
mode flags will be searched for within the specified monitor
fd set.  If the fd is found, a dup of the fd will be returned
from qemu_open.

Signed-off-by: Corey Bryant <coreyb linux vnet ibm com>

  cutils.c      |    5 +++
  monitor.c     |   83 ++++++++++++++++++++++++++++++++++++++++++-
  monitor.h     |    5 +++
  osdep.c       |  109 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  qemu-common.h |    1 +
  qemu-tool.c   |   20 +++++++++++
  6 files changed, 222 insertions(+), 1 deletion(-)

This breaks the build of vscclient and the qtest cases, because osdep.c
has now a new dependency on the fdset monitor functions. The easy way to
fix it would be to squash the following in (linking vscclient and qtests
with qemu-tool.o). Any objections?

Kevin


Sorry about that. Now I know to run make check. :) I don't have any objections to this fix. I ran my tests again with this and there weren't any problems.

--
Regards,
Corey


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]