[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 5/5] Update the remote API

On 08/14/2012 02:19 PM, Marcelo Cerri wrote:
> Hi Michal,
> I'm updating the patch series, but I have a few questions below:
> On 08/06/2012 10:29 AM, Michal Privoznik wrote:
>> On 03.08.2012 16:18, Marcelo Cerri wrote:
>>> ...
>>>   +LIBVIRT_0.10.1{
>>> +    global:
>>> +        virDomainGetSecurityLabelList;
>>> +} LIBVIRT_0.10.0;
>>> +
>> Since 0.10.0 is not out yet, I guess this can be squashed into 0.10.0
>> (okay, we've release -rc0 but that's because patch flow is lower making
>> our release prolonged about twice).
> Can you tell me in which version I can include it now?

Include it in the existing LIBVIRT_0.10.0{} chunk.

>> --- remote_protocol-structs     2012-08-06 14:47:40.813120178 +0200
>> +++ remote_protocol-struct-t3   2012-08-06 15:22:39.223650145 +0200
>> @@ -749,6 +749,16 @@
>>           } label;
>>           int                        enforcing;
>>   };
>> +struct remote_domain_get_security_label_list_args {

> Why did you want to change this?

This file is generated by 'make check' _if_ you have 'pdwtags' installed
(part of the 'dwarves' package on Fedora), and keeping it in version
control forces reviewers to notice if we are breaking RPC ABI
compatibility (strict addition of new structs is okay, changing of
existing structs is generally not okay).  Apparently you didn't have
pdwtags available, so Michal is showing what you'd have to change to
pass 'make check' for those of us that do have it installed.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]