[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] parallels: change URI to parallels:///system



On Mon, Aug 13, 2012 at 07:50:12PM +0400, Dmitry Guryanov wrote:
> Let's change URI to parallels:///system. Parallels Server supports
> creating VMs from non-privileged accounts, but it's not main usage
> scenario and it may be forbidden in the future.
> 
> Also containers, which will be supported by the driver, can be managed
> only by root, so /system path is more suitable for this driver.
[...]
> diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
> index 05db54f..53b5a50 100644
> --- a/src/parallels/parallels_driver.c
> +++ b/src/parallels/parallels_driver.c
> @@ -670,11 +670,11 @@ parallelsOpen(virConnectPtr conn,
>          (conn->uri->path[0] == '/' && conn->uri->path[1] == '\0')) {
>          virReportError(VIR_ERR_INVALID_ARG, "%s",
>                         _("parallelsOpen: supply a path or use "
> -                         "parallels:///session"));
> +                         "parallels:///system"));
>          return VIR_DRV_OPEN_ERROR;
>      }
>  
> -    if (STREQ(conn->uri->path, "/session"))
> +    if (STREQ(conn->uri->path, "/system"))
>          ret = parallelsOpenDefault(conn);
>      else
>          return VIR_DRV_OPEN_DECLINED;

  Hum, Okay, the rc0 is not a release so we can still break things
so better fix this early than late !

ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]