[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 4/9] util: utility functions for virNetDevVPortProfile



On 08/15/2012 10:44 AM, Viktor Mihajlovski wrote:
> On 08/14/2012 09:04 AM, Laine Stump wrote:
>>
>> +    /* at least one of the source profiles is non-empty */
>> +    if (VIR_ALLOC(*result) < 0) {
> I get a compile error here:
> cc1: warnings being treated as errors
> ../../src/util/virnetdevvportprofile.c: In function
> 'virNetDevVPortProfileMerge3':
> ../../src/util/virnetdevvportprofile.c:412: error: implicit
> declaration of function 'VIR_ALLOC' [-Wimplicit-function-declaration]
> ../../src/util/virnetdevvportprofile.c:412: error: nested extern
> declaration of 'VIR_ALLOC' [-Wnested-externs]

Ah - you must be configured --vithout-virtualport (do you have a very
old kernel?) Can you try this patch to see if it solves your problem? If
so I'll push it as a build breaker:

diff --git a/src/util/virnetdevvportprofile.c
b/src/util/virnetdevvportprofile.c
index e686fd9..a789a34 100644
--- a/src/util/virnetdevvportprofile.c
+++ b/src/util/virnetdevvportprofile.c
@@ -24,6 +24,7 @@
 
 #include "virnetdevvportprofile.h"
 #include "virterror_internal.h"
+# include "memory.h"
 
 #define VIR_FROM_THIS VIR_FROM_NET
 
@@ -52,7 +53,6 @@ VIR_ENUM_IMPL(virNetDevVPortProfileOp,
VIR_NETDEV_VPORT_PROFILE_OP_LAST,
 
 # include "virnetlink.h"
 # include "virfile.h"
-# include "memory.h"
 # include "logging.h"
 # include "virnetdev.h"
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]