[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 15/23] Add JSON serialization of virNetServerClientPtr objects for process re-exec()



On 08/09/2012 09:20 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Add two new APIs virNetServerClientNewPostExecRestart and
> virNetServerClientPreExecRestart which allow a virNetServerClientPtr
> object to be created from a JSON object and saved to a
> JSON object, for the purpose of re-exec'ing a process.
> 
> This includes serialization of the connected socket associated
> with the client
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---

> +virNetServerClientPtr virNetServerClientNewPostExecRestart(virJSONValuePtr object,
> +                                                           virNetServerClientPrivNewPostExecRestart privNew,
> +                                                           virNetServerClientPrivPreExecRestart privPreExecRestart,
> +                                                           virFreeCallback privFree,
> +                                                           void *privOpaque)
> +{
> +    virJSONValuePtr child;
> +    virNetServerClientPtr client = NULL;
> +    virNetSocketPtr sock;
> +    const char *identity = NULL;
> +    int auth;
> +    bool readonly;
> +    unsigned int nrequests_max;
> +
> +    if (virJSONValueObjectGetNumberInt(object, "auth", &auth) < 0) {
> +        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> +                       _("Missing auth field in JSON state document"));
> +        return NULL;
> +    }
> +    if (virJSONValueObjectGetBoolean(object, "readonly", &readonly) < 0) {
> +        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> +                       _("Missing readonly field in JSON state document"));
> +        return NULL;
> +    }
> +    if (virJSONValueObjectGetNumberUint(object, "nrequests_max",
> +                                        (unsigned int *)&nrequests_max) < 0) {

Why the cast?  &nrequests_max is already (unsigned int *).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]