[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/7] Add function virDevicePCIAddressEqual



On 08/16/2012 04:07 PM, Eric Blake wrote:
> On 08/16/2012 09:42 AM, Shradha Shah wrote:
>> This function is needed by the network driver in a later commit.
>> This function is useful in functions like networkNotifyActualDevice
>> and networkReleaseActualDevice
>> ---
>>  src/conf/device_conf.c   |   16 ++++++++++++++++
>>  src/conf/device_conf.h   |    3 +++
>>  src/libvirt_private.syms |    1 +
>>  3 files changed, 20 insertions(+), 0 deletions(-)
>> +++ b/src/libvirt_private.syms
>> @@ -224,6 +224,7 @@ virDeviceAddressPciMultiTypeToString;
>>  virDevicePCIAddressIsValid;
>>  virDevicePCIAddressParseXML;
>>  virDevicePCIAddressFormat;
>> +virDevicePCIAddressEqual;
> Several patches have now failed to sort this section of the file.  I'm
> okay with either rebasing to touch it up as you go, or one big cleanup
> at the end of the series.
>

Now that you've pointed it out, I'm just squashing in the simple fixes
to keep the order alphabetic as they go (along with a few other minor
changes like extra spaces at the end of lines, etc). (Doing a "make
check" and "make syntax-check" after applying each patch, I also found
some problems in 3/7 that cause networkxml2xmltest to fail - that
required enough changes that I'll be posting a patch for review (and
squashing into 3/7 before pushing) rather than just silently squashing
in the changes.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]