[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [test-API][PATCH 2/3] Modify function name to avoid key word 'check' in framework



On 08/17/2012 12:06 PM, Wayne Sun wrote:
>   Modfiy the function name to avoid generating check case and
>   doing params check before the case run.
> 
> Signed-off-by: Wayne Sun <gsun redhat com>
> ---
>  repos/domain/cpu_topology.py |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/repos/domain/cpu_topology.py b/repos/domain/cpu_topology.py
> index f0f081c..5f4ef52 100644
> --- a/repos/domain/cpu_topology.py
> +++ b/repos/domain/cpu_topology.py
> @@ -120,7 +120,7 @@ def guest_start(domobj, guestname, logger):
>  
>      return 0, ip
>  
> -def cpu_topology_check(ip, username, password,
> +def cpu_topology_chk(ip, username, password,
>                         sockets, cores, threads, logger):
>      """login the guest, run lscpu command to check the result"""
>      lscpu = "lscpu"
> @@ -194,7 +194,7 @@ def cpu_topology(params):
>      if ret:
>          return 1
>  
> -    if cpu_topology_check(ip, username, password,
> +    if cpu_topology_chk(ip, username, password,
>                            sockets, cores, threads, logger):
>         return 1
>  
> 

Makes sense, ACK,

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]