[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/7] add qemuAgentCommand() for .qemuAgentCommand to remote driver



On 08/20/2012 02:20 AM, MATSUDA, Daiki wrote:
> (2012/08/16 22:25), Martin Kletzander wrote:
>> On 08/15/2012 03:36 AM, MATSUDA Daiki wrote:
>>> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
>>> index 353a153..3c60709 100644
>>> --- a/src/remote/remote_driver.c
>>> +++ b/src/remote/remote_driver.c
>>> @@ -5368,6 +5368,7 @@ static virDriver remote_driver = {
>>>       .domainSetMetadata = remoteDomainSetMetadata, /* 0.9.10 */
>>>       .domainGetMetadata = remoteDomainGetMetadata, /* 0.9.10 */
>>>       .domainGetHostname = remoteDomainGetHostname, /* 0.10.0 */
>>> +    .qemuAgentCommand = qemuAgentCommand, /* 0.10.0 */
>>
>> You probably want to call some function like
>> 'remoteQemuDomainAgentCommand' or something like that since
>> qemuAgentCommand works locally and not remotely.
> 
> Yes. But the function name is generated automatically from
> QEMU_RPOC_AGNET_COMMAND.
> And I will change it on next version. So, do you have suggestion name?
> qemuDomainAgentCommand() from QEMU_PROC_DOMAIN_AGENT_COMMAND ?
> 

My concern wasn't about the function name. The problem is that there is
no remote call. The function you are assigning here operates on local
machine and not on the connected daemon side (there is no 'call()' in
the stack). OTOH I haven't wrote an API myself, so I'm not in the right
position to comment on this with a lot of self-confidence (I just took
an inspiration out of other commands, mainly qemuMonitor*), so others
opinions are welcomed.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]