[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] network: implement virNetworkDefineXMLFlags for bridge_driver



On 08/20/2012 12:17 AM, Laine Stump wrote:
> Just add an entry to the function table, rename the original
> virNetworkDefineXML to virNetworkDefineXMLFlags (with a check for
> flags == 0), and add a one line replacement for virNetworkDefineXML
> that calls virNetworkDefineXMLFlags.
> ---
>  src/network/bridge_driver.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
> index bff2d30..e2b569f 100644
> --- a/src/network/bridge_driver.c
> +++ b/src/network/bridge_driver.c
> @@ -2339,7 +2339,10 @@ cleanup:
>      return ret;
>  }
>  
> -static virNetworkPtr networkDefine(virConnectPtr conn, const char *xml) {
> +static
> +virNetworkPtr networkDefineXMLFlags(virConnectPtr conn, const char *xml,
> +                                    unsigned int flags)

Unusual formatting.  When using split line declarations, our style is:

static virNetworkPtr
networkDefineXMLFlags(...)

That is, the function name always starts in column 1 in split style.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]