[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] Add helper library for testing the qemu monitor code



On Mon, Aug 20, 2012 at 08:11:14AM -0600, Eric Blake wrote:
> On 08/20/2012 07:49 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > To be able to test the QEMU monitor code, we need to have a fake
> > QEMU monitor server. This introduces a simple (dumb) framework
> > that can do this. The test case registers a series of items to
> > be sent back as replies to commands that will be executed. A
> > thread runs the event loop looking for incoming replies and
> > sending back this pre-registered data. This allows testing all
> > QEMU monitor code that deals with parsing responses and errors
> > from QEMU, without needing QEMU around
> 
> Very sorely needed.  Thanks for hacking this up, and hopefully it is
> easily extensible.
> 
> > +++ b/cfg.mk
> > @@ -741,7 +741,7 @@ exclude_file_name_regexp--sc_copyright_address = \
> >  exclude_file_name_regexp--sc_flags_usage = ^(docs/|src/util/virnetdevtap\.c$$)
> >  
> >  exclude_file_name_regexp--sc_libvirt_unmarked_diagnostics = \
> > -  ^src/rpc/gendispatch\.pl$$
> > +  ^(src/rpc/gendispatch\.pl$$|tests/)
> 
> A rather heavy hammer for just one added test, but makes sense (tests
> aren't installed, so translating them is pointless).

That was an intentionally heavy hammer.  We shouldn't waste translators
time on messages in the tests/ directory. In fact we should probably
write a syntax-check rule to *forbid* use of _(...) in tests/ directory
completely, rather than just whitelisted the existing rule.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]