[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] Add helper library for testing the qemu monitor code



On 08/20/2012 08:13 AM, Daniel P. Berrange wrote:
>>>  exclude_file_name_regexp--sc_libvirt_unmarked_diagnostics = \
>>> -  ^src/rpc/gendispatch\.pl$$
>>> +  ^(src/rpc/gendispatch\.pl$$|tests/)
>>
>> A rather heavy hammer for just one added test, but makes sense (tests
>> aren't installed, so translating them is pointless).
> 
> That was an intentionally heavy hammer.  We shouldn't waste translators
> time on messages in the tests/ directory. In fact we should probably
> write a syntax-check rule to *forbid* use of _(...) in tests/ directory
> completely, rather than just whitelisted the existing rule.

True enough - I can whip one up.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]