[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 8/4] virsh: split out virsh-host.c



On 08/20/2012 04:13 PM, Eric Blake wrote:
> The splits are getting easier, with fewer cleanups needed in virsh.h.
>
> * tools/virsh-host.h: New file.
> * tools/Makefile.am (virsh_SOURCES): Build it.
> * tools/virsh-host.c: Use new header.
> * tools/virsh.c: Likewise.
> ---
>  tools/Makefile.am  |  2 +-
>  tools/virsh-host.c | 16 +++++++++++++++-
>  tools/virsh-host.h | 33 +++++++++++++++++++++++++++++++++
>  tools/virsh.c      |  2 +-
>  4 files changed, 50 insertions(+), 3 deletions(-)
>  create mode 100644 tools/virsh-host.h


Disclaimer: all of my reviews in this series are based purely on a
manual examination of the diffs and the assumption that "make check &&
make syntax-check" passes with no errors.

That said, this one seems pretty clear. ACK.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]