[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4] qemu: Unify port-wise SPICE and VNC behavior



On Tue, Aug 14, 2012 at 02:52:19PM +0200, Martin Kletzander wrote:
> Port allocations for SPICE and VNC behave almost the same (with
> default ports), but there is some mess in the code. This patch clears
> these inconsistencies and makes sure the same behavior will be used
> when ports for remote displays are changed.
> 
> Changes:
>  - hard-coded number 5900 removed (handled elsewhere like with VNC)
>  - reservedVNCPorts renamed to reservedRemotePorts (it's not just for
>    VNC anymore)
>  - QEMU_VNC_PORT_{MIN,MAX} renamed to QEMU_REMOTE_PORT_{MIN,MAX}
>  - port allocation unified for VNC and SPICE
> ---
>  src/conf/domain_conf.c  |    2 +-
>  src/qemu/qemu_command.h |    4 ++--
>  src/qemu/qemu_conf.h    |    2 +-
>  src/qemu/qemu_driver.c  |   11 +++--------
>  src/qemu/qemu_process.c |   27 +++++++++++++--------------
>  5 files changed, 20 insertions(+), 26 deletions(-)

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]