[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/1] build: work with glibc that lacks CPU_COUNT



On Tue, Aug 21, 2012 at 11:17:21AM -0600, Eric Blake wrote:
> Building on RHEL 5 warned:
> 
> nodeinfo.c: 305: warning: implicit declaration of function 'CPU_COUNT'
> 
> This extension macro in <sched.h> was not added until later glibc.
> 
> * src/nodeinfo.c (CPU_COUNT): Add fallback implementation.
> ---
> 
> Pushing under the build-breaker rule.  I'm still getting link
> failures:
> 
> ./.libs/libvirt_util.a(libvirt_util_la-virobject.o): In function `virAtomicIntXor':
> /home/dummy/l,ibvirt/src/util/viratomoic.h:404: multiple definition of `virAtomicIntXor'
> ./.libs/libvirt_util.a(libvirt_util_la-viratomic.o):/home/dummy/libvirt/src/util/viratomic.h:404: first defined here

Hmm, that seems to suggested that when viratomic.c #includes
viratomic.h, GCC is instantiating the functions, even though
they're declared inline.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]