[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] additional parameter needed for dnsmasq

On 08/22/2012 10:48 AM, Claudio Bley wrote:
+    virCommandAddArgFormat(cmd,
> >>>+                "--domain %s --local=/%s/",
> >>>+                network->def->domain,
> >>>+                network->def->domain);
Here, you're adding "--domain D --local=/D/" as a*single*  argument to
the dnsmasq call.

You need to provide "--domain", network->def->domain, "--local=/D/" as
3 arguments to the call, ie. first use
virCommandAddArgPair(cmd, "--domain", D), then use virCommandAddArgFormat
for the --local part.
Much thanks.  That did the trick.

I also now see what the tests are doing ... going to need to change the file pairs for all nine test. Oh well, it cannot be that much work.

BTW, even if a domain name is not specified, the "--local=//" is needed so that most stuff is not forwarded. For some reason, dnsmasq wants to forward and MX queries. I am going to take that issue up with the dnsmasq folks directly.

I will re-post the patches when I complete and test them.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]