[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] (updated) additional parameters needed for dnsmasq



On 08/22/2012 01:36 PM, Gene Czarcinski wrote:

>> Oh, and now that I've already pushed, I have a high-level question: what
>> is the minimum version of 'dnsmasq' that supports the command-line
>> syntax that this patch introduces?
>>
> I went back and checked some of the  older versions of dnsmasq (2.41 and
> 2.37).  local=//, --domain-needed, and --filterwin2k are all present in

That should be good enough.  Thanks for the research!

> the example dnsmasq.conf files.  This is not to say the the dnsmasq
> software does exactly the same thing in all versions. According the the
> CHANGELOG, there was some code "tweaking" for domain-needed in 2.58.

May be true, but hopefully we'll get a decent report if someone runs
into subtleties caused by this; but at least we know we won't hit anyone
complaining that dnsmasq no longer starts due to unknown options.

> 
> I am truly sorry that my patch and email made life a bit difficult for
> you.  I have not delved into any of the virtualization code and your
> setup & convensions are all reasonable but I just did not know.  The
> last package I hacked around with was NetworkManager and libvirt is a
> lot different.

No problem - we're used to helping out first-time contributors.  Open
source is successful when you give people the benefit of a doubt, and
encourage their contribution in spite of difficulties.  On the converse
side, touching up every single patch doesn't scale well, which is why we
write HACKING documents, and why we try to be friendly even when asking
for a re-submission, and why we aren't quite so lenient on HACKING
violations from repeated contributors.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]