[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] virsh: Check for connection usability before each command



On 08/24/2012 02:42 PM, Peter Krempa wrote:
> Some commands in virsh forgot to do this check before executing remote commands
> and printed unexpected error messages. This series moves the connection check
> to a central point so that these mistakes don't happen. Also it's a nice
> cleanup :).
> 
> Peter Krempa (2):
>   virsh: Improve checking for connection when running commands
>   virsh: remove unneeded usage of vshConnectionUsability()
> 
>  tools/virsh-domain-monitor.c |  36 --------
>  tools/virsh-domain.c         | 215 -------------------------------------------
>  tools/virsh-host.c           |  40 --------
>  tools/virsh-interface.c      |  40 --------
>  tools/virsh-network.c        |  35 -------
>  tools/virsh-nodedev.c        |  18 ----
>  tools/virsh-nwfilter.c       |  15 ---
>  tools/virsh-pool.c           |  57 ------------
>  tools/virsh-secret.c         |  18 ----
>  tools/virsh-snapshot.c       |  30 ------
>  tools/virsh-volume.c         |  50 ----------
>  tools/virsh.c                |  46 +++++----
>  tools/virsh.h                |   1 -
>  13 files changed, 28 insertions(+), 573 deletions(-)
> 

Looks clean and everything I tried works, so ACK series,

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]