[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] xen-xs: fix uuid of renamed domain



On 08/24/2012 06:58 AM, Philipp Hahn wrote:
> When the XenStore tdb lives persistently and is not cleared between host
> reboots, Xend (version 3.4 and 4.1) re-creates the domain information
> located in XenStore below /vm/$UUID. (According to the xen-3.2-commit
> hg265950e3df69 to fix a problem when locally migrating a domain to the
> host itself.)
> 
> When doing so a version number is added to the UUID separated by one
> dash, which confuses xenStoreDomainIntroduced(): It iterates over all
> domains and tries to lookup all inactive domains using
> xenStoreDomainGetUUID(), which fails if the running domain is renamed:
> virUUIDParse() fails to parse the versioned UUID and the domain is
> flagged as missing. When this happens the function delays .2s and
> re-tries 20 times again, multiplied by the number of renamed VMs.
>   14:48:38.878: 4285: debug : xenStoreDomainIntroduced:1354 : Some domains were missing, trying again

> The patch adds truncation of the UUID as read from the XenStore path
> before passing it to virUUIDParse().
> 
> The same issue is reported at
> <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=666135>
> 
> Signed-off-by: Philipp Hahn <hahn univention de>
> ---
>  src/xen/xs_internal.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)

ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]