[libvirt] [PATCHv2 3/3] snapshot: rename an enum

Eric Blake eblake at redhat.com
Fri Aug 24 16:17:13 UTC 2012


On 08/24/2012 09:57 AM, Daniel Veillard wrote:
>>>   ACK, the only annoyance is that the name being longuer the simple
>>> substitution leads to lines over 80 characters, I would be a proponent
>>> of dropping the indentation to the opening ( for the sake of keeping
>>> everything on one 80 char line
>>

>> Should I go ahead and push the patch as-is, or go with one of the
>> shorter names?  After all, long lines are a cosmetic issue, and I'd
>> rather code with long names that are legible than short names that leave
>> me scratching my head.
> 
>   Oh, sure push :-)

Done.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120824/eb79f8d5/attachment-0001.sig>


More information about the libvir-list mailing list