[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Introduce new VIR_ERR_AGENT_UNRESPONSIVE error code



On 27.08.2012 14:11, Martin Kletzander wrote:
> On 08/27/2012 01:57 PM, Michal Privoznik wrote:
>> Currently, when guest agent is configure but not responsive
> 
> s/configure/configured/
> 
>> (e.g. due to appropriate service not running in the guest)
>> we return VIR_ERR_INTERNAL_ERROR or VIR_ERR_ARGUMENT_UNSUPPORTED.
> 
> There is no VIR_ERR_ARGUMENT_UNSUPPORTED in the patch.
> 
>> Both are wrong. Therefore we need to introduce new error code
>> to reflect this case.
>> ---
> 
> ACK with the commit message fixed,

Thanks. I think this is a bug fix rather than enhancement so I've pushed
the whole series. Thanks.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]