[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix define logic



On 08/27/2012 09:59 AM, Michal Privoznik wrote:
> With current flow in qemudDomainDefine we might loose data

s/loose/lose/ (this isn't a case of making data less strict, but a case
of dropping data altogether - it's a shame that this pair of English
words tends to cause disastrous changes in meaning when one is
misspelled for the other).

> when updating an existing domain. We parse given XML and
> overwrite the configuration.  Then we try to save the new
> config. However, this step may fail and we don't perform any
> roll back.  In fact, we remove the domain from the list of
> domains held up by qemu driver. This is okay as long as the
> domain was brand new one.
> ---

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]