[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix define logic



On 27.08.2012 18:54, Eric Blake wrote:
> On 08/27/2012 09:59 AM, Michal Privoznik wrote:
>> With current flow in qemudDomainDefine we might loose data
> 
> s/loose/lose/ (this isn't a case of making data less strict, but a case
> of dropping data altogether - it's a shame that this pair of English
> words tends to cause disastrous changes in meaning when one is
> misspelled for the other).

Yeah. I've got an English dictionary lying around. Maybe one day I'll
actually use it :)

> 
>> when updating an existing domain. We parse given XML and
>> overwrite the configuration.  Then we try to save the new
>> config. However, this step may fail and we don't perform any
>> roll back.  In fact, we remove the domain from the list of
>> domains held up by qemu driver. This is okay as long as the
>> domain was brand new one.
>> ---
> 
> ACK.

Thanks, pushed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]